Handle sendKeyPress events for temporary integrated consoles
#3951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes our custom named pipe debug adaptor. It was used primarily for logging, but until we actually need to log at these logs, let's reduce code complexity and rely on VS Code's built-in implementation.
The second commit registers a handler to send a key press to the spawned temporary integrated console. Note that the DAP specification is slightly different from the LSP specification. In PowerShell/PowerShellEditorServices#1791, we use the same
sendNotification, which comes across DAP as a debug session custom event (not a notification).Note that we seem to only support one temporary integrated console / process at a time, though I don't see anything explicitly calling that out.
Fixes #3950.